Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Next.js 9.5.4-canary.4 #161

Merged
merged 14 commits into from
Sep 7, 2020
Merged

Upgrade to Next.js 9.5.4-canary.4 #161

merged 14 commits into from
Sep 7, 2020

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Sep 7, 2020 •
edited
Loading

Upgrade from 9.4 to 9.5

https://nextjs.org/blog/next-9-5

Specs in #149

@Vadorequest Vadorequest linked an issue Sep 7, 2020 that may be closed by this pull request
Important presets upgrade - Migrate to Next 9.5.x #149
Closed
@Vadorequest Vadorequest self-assigned this Sep 7, 2020
@github-actions
Copy link

github-actions bot commented Sep 7, 2020

❌  Deployment FAILED
Commit e73465b failed to deploy to
click to see logs

@github-actions
Copy link

github-actions bot commented Sep 7, 2020

✅  Deployment SUCCESS
Commit 7ba2361 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-ht1hicqvr.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 7, 2020

✅  E2E tests SUCCESS

@Vadorequest Vadorequest linked an issue Sep 7, 2020 that may be closed by this pull request
@vercel/next Legacy Routes Optimized Lambdas Opt-out #130
Closed
@Vadorequest
Copy link
Member Author

New logs when building with Vercel:
image

https://vercel.com/unly-oss/nrn-v2-mst-aptd-at-lcz-sty-c1/jo9hwjeru

Old logs:
image

https://vercel.com/unly-oss/nrn-v2-mst-aptd-at-lcz-sty-c1/ht1hicqvr

The message about #130 has disappeared as expected.

@github-actions
Copy link

github-actions bot commented Sep 7, 2020

✅  Deployment SUCCESS
Commit 2a45383 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-jo9hwjeru.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 7, 2020

✅  E2E tests SUCCESS

@github-actions
Copy link

github-actions bot commented Sep 7, 2020

✅  Deployment SUCCESS
Commit 006aa1c successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-r13s2uaxo.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 7, 2020

✅  E2E tests SUCCESS

@Vadorequest
Use Html from 'next/document' instead of "html" to avoid "Expected Do…
de3a8ac 
…cument Component Html was not rendered. Make sure you render them in your custom `_document`" warning
@Vadorequest
Make TS types around Static paths/params/props extensible to allow fo…
a082a9f 
…r per-page override (instead of listing all possible values within CommonServerSideParams.ts)
@github-actions
Copy link

github-actions bot commented Sep 7, 2020

✅  Deployment SUCCESS
Commit a082a9f successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-qqfc1xz7u.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 7, 2020

✅  E2E tests SUCCESS

@Vadorequest Vadorequest changed the title Upgrade to Next.js 9.5 Upgrade to Next.js 9.5.4-canary.4 Sep 7, 2020
@Vadorequest Vadorequest merged commit 17f17d9 into v2-mst-aptd-at-lcz-sty Sep 7, 2020
@Vadorequest Vadorequest deleted the upgrade-next-9.5 branch September 7, 2020 14:35
Vadorequest added a commit that referenced this pull request Sep 7, 2020
@Vadorequest
Upgrade to Next.js 9.5.4-canary.4 (#161)
1b01c9d 
Migrate to v9.5.3 is not possible due to [this bug](vercel/next.js#16775), app will be migrated to a canary version for now.
This was referenced Sep 7, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vadorequest Vadorequest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Important presets upgrade - Migrate to Next 9.5.x @vercel/next Legacy Routes Optimized Lambdas Opt-out
1 participant
@Vadorequest